194-fitrange (#219)

keyboard-setting of custom fit range; closes #194; helps for #32

src/gui_qt/fit/fit_parameter.py

@@ -1,14 +1,12 @@
 from __future__ import annotations
 
-from typing import Optional
-
 from nmreval.fit.parameter import Parameter
 from nmreval.utils.text import convert
 
 from ..Qt import QtWidgets, QtCore, QtGui
 from .._py.fitfuncwidget import Ui_FormFit
+from .._py.fitmodelwidget import Ui_FitParameter
 from ..lib.forms import SelectionWidget
-from .fit_forms import FitModelWidget
 
 
 class QFitParameterWidget(QtWidgets.QWidget, Ui_FormFit):
@@ -30,16 +28,15 @@ class QFitParameterWidget(QtWidgets.QWidget, Ui_FormFit):
         self.scrollwidget2.setLayout(QtWidgets.QVBoxLayout())
 
     def eventFilter(self, src: QtCore.QObject, evt: QtCore.QEvent):
+        modifiers = QtCore.Qt.KeyboardModifier.ControlModifier | QtCore.Qt.KeyboardModifier.ShiftModifier
         if isinstance(evt, QtGui.QKeyEvent):
-            if (evt.key() == QtCore.Qt.Key_Right) and \
-                    (evt.modifiers() == QtCore.Qt.ControlModifier | QtCore.Qt.ShiftModifier):
+            if (evt.key() == QtCore.Qt.Key.Key_Right) and (evt.modifiers() == modifiers):
                 self.change_single_parameter(src.value, sender=src)
                 self.select_next_preview(1)
 
                 return True
 
-            elif (evt.key() == QtCore.Qt.Key_Left) and \
-                    (evt.modifiers() == QtCore.Qt.ControlModifier | QtCore.Qt.ShiftModifier):
+            elif (evt.key() == QtCore.Qt.Key.Key_Left) and (evt.modifiers() == modifiers):
                 self.change_single_parameter(src.value, sender=src)
                 self.select_next_preview(-1)
 
@@ -65,7 +62,7 @@ class QFitParameterWidget(QtWidgets.QWidget, Ui_FormFit):
         self.glob_values = [1] * len(func.params)
 
         for k, v in enumerate(func.params):
-            widgt = FitModelWidget(label=v, parent=self.scrollwidget)
+            widgt = ParameterGlobalWidget(name=v, parent=self.scrollwidget)
             widgt.parameter_pos = k
             widgt.func_idx = idx
             try:
@@ -95,7 +92,7 @@ class QFitParameterWidget(QtWidgets.QWidget, Ui_FormFit):
         for w1, w2 in zip(self.global_parameter, self.data_parameter):
             w1.parametername.setFixedSize(self.max_width)
             w1.checkBox.setFixedSize(self.max_width)
-            w2.label.setFixedSize(self.max_width)
+            w2.parametername.setFixedSize(self.max_width)
 
         if hasattr(func, 'choices') and func.choices is not None:
             cbox = func.choices
@@ -175,7 +172,7 @@ class QFitParameterWidget(QtWidgets.QWidget, Ui_FormFit):
         # disable single parameter if it is set global, enable if global is unset
         widget = self.sender()
         idx = self.global_parameter.index(widget)
-        enable = (widget.global_checkbox.checkState() == QtCore.Qt.Unchecked)
+        enable = (widget.global_checkbox.checkState() == QtCore.Qt.CheckState.Unchecked)
         self.data_parameter[idx].setEnabled(enable)
 
     def select_next_preview(self, direction):
@@ -215,7 +212,7 @@ class QFitParameterWidget(QtWidgets.QWidget, Ui_FormFit):
         param_general = []
 
         for g in self.global_parameter:
-            if isinstance(g, FitModelWidget):
+            if isinstance(g, ParameterGlobalWidget):
                 p_i, bds_i, fixed_i, global_i = g.get_parameter()
                 parameter_i = Parameter(name=g.name, value=p_i, lb=bds_i[0], ub=bds_i[1], var=fixed_i)
                 param_general.append(parameter_i)
@@ -236,7 +233,7 @@ class QFitParameterWidget(QtWidgets.QWidget, Ui_FormFit):
             p = []
 
             for i, (p_i, g) in enumerate(zip(parameter, self.global_parameter)):
-                if isinstance(g, FitModelWidget):
+                if isinstance(g, ParameterGlobalWidget):
                     if (p_i is None) or is_global[i]:
                         # set has no oen value
                         p.append(param_general[i].copy())
@@ -303,8 +300,8 @@ class ParameterSingleWidget(QtWidgets.QWidget):
         self._init_ui()
 
         self.name = name
-        self.label.setText(convert(name))
-        self.label.setToolTip('If this is bold then this parameter is only for this data. '
+        self.parametername.setText(convert(name))
+        self.parametername.setToolTip('If this is bold then this parameter is only for this data. '
                               'Otherwise, the general parameter is used and displayed')
 
         # self.value_line.setValidator(QtGui.QDoubleValidator())
@@ -316,8 +313,8 @@ class ParameterSingleWidget(QtWidgets.QWidget):
         layout.setContentsMargins(2, 2, 2, 2)
         layout.setSpacing(2)
 
-        self.label = QtWidgets.QLabel(self)
-        layout.addWidget(self.label)
+        self.parametername = QtWidgets.QLabel(self)
+        layout.addWidget(self.parametername)
 
         layout.addSpacerItem(QtWidgets.QSpacerItem(0, 0, QtWidgets.QSizePolicy.Expanding, QtWidgets.QSizePolicy.Minimum))
 
@@ -347,6 +344,133 @@ class ParameterSingleWidget(QtWidgets.QWidget):
 
     def show_as_local_parameter(self, is_local: bool):
         if is_local:
-            self.label.setStyleSheet('font-weight: bold;')
+            self.parametername.setStyleSheet('font-weight: bold;')
         else:
-            self.label.setStyleSheet('')
+            self.parametername.setStyleSheet('')
+
+
+class ParameterGlobalWidget(QtWidgets.QWidget, Ui_FitParameter):
+    """
+    Widget to show a global parameter
+    """
+
+    value_requested = QtCore.pyqtSignal(object)
+    value_changed = QtCore.pyqtSignal(str)
+    state_changed = QtCore.pyqtSignal()
+    replace_single_value = QtCore.pyqtSignal(object)
+
+    def __init__(self, name: str = 'Fitparameter', parent=None, fixed: bool = False):
+        super().__init__(parent)
+        self.setupUi(self)
+
+        self.name = name
+        self.reset_button.setVisible(False)
+
+        self.parametername.setText(convert(name) + ' ')
+
+        self.parameter_line.setText('1')
+        self.parameter_line.setMaximumWidth(160)
+        self.lineEdit.setMaximumWidth(100)
+        self.lineEdit_2.setMaximumWidth(100)
+
+        self.label_3.setText(f'< {convert(name)} <')
+
+        self.checkBox.stateChanged.connect(self.enableBounds)
+        self.global_checkbox.stateChanged.connect(lambda: self.state_changed.emit())
+        self.parameter_line.editingFinished.connect(self.update_parameter)
+        self.parameter_line.values_requested.connect(lambda: self.value_requested.emit(self))
+        self.parameter_line.replace_single_values.connect(lambda: self.replace_single_value.emit(None))
+        self.parameter_line.editingFinished.connect(lambda: self.value_changed.emit(self.parameter_line.text()))
+        self.fixed_check.toggled.connect(self.set_fixed)
+
+        if fixed:
+            self.fixed_check.hide()
+
+        self.reset_button.setVisible(False)
+
+        self.parameter_pos = None
+        self.func_idx = None
+
+        self._linetext = '1'
+
+        self.menu = QtWidgets.QMenu(self)
+
+    def set_parameter_string(self, p: str):
+        self.parameter_line.setText(p)
+        self.parameter_line.setToolTip(p)
+
+    def set_bounds(self, lb: float, ub: float, cbox: bool = True):
+        self.checkBox.setCheckState(QtCore.Qt.CheckState.Checked if cbox else QtCore.Qt.CheckState.Unchecked)
+        for val, bds_line in [(lb, self.lineEdit), (ub, self.lineEdit_2)]:
+            if val is not None:
+                bds_line.setText(str(val))
+            else:
+                bds_line.setText('')
+
+    def enableBounds(self, value: int):
+        self.lineEdit.setEnabled(value == 2)
+        self.lineEdit_2.setEnabled(value == 2)
+
+    def set_parameter(self, p: float | None, bds: tuple[float, float, bool] = None,
+                      fixed: bool = None, glob: bool = None):
+        ptext = f'{p:.4g}'
+
+        self.set_parameter_string(ptext)
+
+        if bds is not None:
+            self.set_bounds(*bds)
+
+        if fixed is not None:
+            self.fixed_check.setCheckState(QtCore.Qt.CheckState.Unchecked if fixed else QtCore.Qt.CheckState.Checked)
+
+        if glob is not None:
+            self.global_checkbox.setCheckState(QtCore.Qt.CheckState.Checked if glob else QtCore.Qt.CheckState.Unchecked)
+
+    def get_parameter(self):
+        try:
+            p = float(self.parameter_line.text().replace(',', '.'))
+        except ValueError:
+            p = self.parameter_line.text().replace(',', '.')
+
+        if self.checkBox.isChecked():
+            lb_text = self.lineEdit.text()
+            lb = None
+            if lb_text:
+                try:
+                    lb = float(lb_text.replace(',', '.'))
+                except ValueError:
+                    lb = lb_text
+
+            ub_text = self.lineEdit_2.text()
+            rb = None
+            if ub_text:
+                try:
+                    rb = float(ub_text.replace(',', '.'))
+                except ValueError:
+                    rb = ub_text
+        else:
+            lb = rb = None
+
+        bounds = (lb, rb)
+
+        return p, bounds, not self.fixed_check.isChecked(), self.global_checkbox.isChecked()
+
+    @QtCore.pyqtSlot(bool)
+    def set_fixed(self, state: bool):
+        # self.global_checkbox.setVisible(not state)
+        self.frame.setVisible(not state)
+
+    @QtCore.pyqtSlot()
+    def update_parameter(self):
+        new_value = self.parameter_line.text()
+        if not new_value:
+            self.parameter_line.setText('1')
+
+        try:
+            float(new_value)
+            is_text = False
+        except ValueError:
+            is_text = True
+            self.global_checkbox.setCheckState(False)
+
+        self.set_fixed(is_text or self.fixed_check.isChecked())