Remove dangling links after graph deletion #150
Closed
opened 2023-11-21 09:09:43 +00:00 by saeckech
·
5 comments
No Branch/Tag Specified
Labels
Clear labels
Kind/Breaking
Kind/Bug
Kind/Crash
Kind/Documentation
Kind/Enhancement
Kind/Feature
Reviewed/Won't Fix
Type/BDS
Type/DSC
Type/Fit
Type/General
Type/NMR
Breaking change that won't be backward compatible
Something is not working
This issue describes unexpected shutdowns or non-responsive behaviors
Improves documentation
Improve existing functionality
New feature
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Priority
Very low
The priority is very low
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid isssue
This issue won't be fixed
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Status
On Hold
This issue or pull request is on hold
Status
Stale
Issues without activity for more than 6 months
Issues connected to BDS
Issues connected to DSC
Issue is connected to fitting data
issue connected to general functionality
Issues connected to NMR
Milestone
No items
No Milestone
Assignees
aahmad (Arshid Ahmad)
anisar (Aqsa Nisar)
ckolb (Christian Kolb)
cwolter (Celine Wolter)
dominik (Dominik Demuth)
dwuerz (David Würz)
elisa (Elisa Steinruecken)
fwolter (Finn Wolter)
huczhang (Huanchen Zhang)
jepsinrajkp (Jepsinraj Kakkuzhiyulla Parambath)
kschroeder (Katharina Schroeder)
malbrecht (Maximilian Albrecht)
mandal (Suvendu Mandal)
markusro (Markus Rosenstihl)
mbergmann (Mark Bergmann)
mhaneke (Markus Haneke)
robin (Robin Horstmann)
saeckech (Christoph Säckel)
skloth (Sebastian Kloth)
skrueger (Sandra Krüger)
ypiliauskaya (Yauheniya Piliauskaya)
Clear assignees
No Assignees
dominik
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: IPKM/nmreval#150
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Ich wollte mir die Werte von ein paar Datensätzen ansehen, allerdings zeigt der Values Reiter nur leere Auswahlfelder an. Das Error Log sagt:
21/11/2023 10:07:23 - ERROR - root : Uncaught exception:
Traceback (most recent call last):
File "/tmp/.mount_NMRevaDcTXZO/usr/src/gui_qt/main/mainwindow.py", line 548, in toggle_tabs
pick_required, block_window = self._select_ptswidget(widget == self.ptsselectwidget, False, False)
File "/tmp/.mount_NMRevaDcTXZO/usr/src/gui_qt/main/mainwindow.py", line 568, in _select_ptswidget
g = self.management.graphs[self.ptsselectwidget.connected_figure]
KeyError: '8f68e7bc-8bed-4ce9-bf42-71051b5ee814'
Falls es hilft: ich habe direkt davor ein paar Graphen gelöscht.
Ist auch nach einem Programmneustart noch kaputt. (Der Key Error ist diesmal anders.)
Beim Versuch die Daten zu fitten passiert nichts. Im Error Log steht:
21/11/2023 13:33:53 - WARNING - root : Fit dialog is not connected graph: Fit None, current graph: e6a3eb10-b24e-43bd-9680-0ad36dbf58b2 (True)
Programm nochmal neustarten hat geholfen. Values und Fits funktionieren wieder wie gewohnt.
Values kaputto Remove dangling links after graph deletionZurück ans Zeichenbrett 🫤
File "/tmp/.mount_NMRevamMrIm6/usr/src/gui_qt/main/mainwindow.py", line 557, in toggle_tabs
pick_required, block_window = self._select_ptswidget(widget == self.ptsselectwidget, False, False)
File "/tmp/.mount_NMRevamMrIm6/usr/src/gui_qt/main/mainwindow.py", line 577, in _select_ptswidget
g = self.management.graphs[self.ptsselectwidget.connected_figure]
Ich wollte eben ein paar Datensätze fitten (basic->exponential function, sign=decaying, x0type=rate). Das ging aber leider schief als ich x0 global fitten wollte. Bei individuellen Fits gibts keine Probleme. In beiden Fällen habe ich eine Custom Fit Range gesetzt. Der (globale) Fit läuft an, es erscheint aber keine Fitvorschau. Stattdessen gibts eine Fehlermeldung mit einem KeyError, die mich an issue#150 erinnert.
ErrorLog:
15/12/2023 11:46:14 - INFO - root : Successful fit
15/12/2023 11:46:14 - ERROR - root : Uncaught exception:
Traceback (most recent call last):
File "/tmp/.mount_NMReval15HmZ/usr/src/gui_qt/main/mainwindow.py", line 976, in show_fit_results
self.fitresult_dialog(results)
File "/tmp/.mount_NMReval15HmZ/usr/src/gui_qt/fit/result.py", line 88, in call
self.set_results(results)
File "/tmp/.mount_NMReval15HmZ/usr/src/gui_qt/fit/result.py", line 106, in set_results
self.set_parameter(0)
File "/tmp/.mount_NMReval15HmZ/usr/src/gui_qt/fit/result.py", line 134, in set_parameter
self.show_results(idx)
File "/tmp/.mount_NMReval15HmZ/usr/src/gui_qt/fit/result.py", line 148, in show_results
self.set_statistics(set_id)
File "/tmp/.mount_NMReval15HmZ/usr/src/gui_qt/fit/result.py", line 282, in set_statistics
best_idx = col if best_val > stats[k] else max(0, best_idx)
KeyError: 'AICc'
Different from this issue, new issue #181 created