[BUG] fit curve not plotted after preview #245

New Issue

saeckech · 2024-02-12T18:28:28Z

saeckech commented

2024-02-12 18:28:28 +00:00

Current behavior

Fit (straight line) seems to work well up to the fit-result-preview, even gives reasonable parameters and matches the datapoints in the fit-result-preview. However when the fit is accepted ("ok" button in the fit-result-preview dialogue) while the 'extrapolate curves' option is checked, an error message (see below) appears. The fitparameters are saved to the dataset and the fit-settings-preview appears to work with them. The actual fit or extrapolation is however not displayed and no set is created. Without the extrapolate option it works as expected.

Version

2024-02-11

Expected behavior

No response

Steps to reproduce

No response

Log messages

12/02/2024 19:19:29 - INFO - root : Successful fit
12/02/2024 19:19:50 - ERROR - root : Uncaught exception:
Traceback (most recent call last):
  File "/tmp/.mount_NMRevao32Zhl/usr/src/gui_qt/main/mainwindow.py", line 969, in accepts_fit
    self.management.make_fits(res, opts, param_graph, show_fit, parts, extrapolate)
  File "/tmp/.mount_NMRevao32Zhl/usr/src/gui_qt/main/management.py", line 650, in make_fits
    fit = fit.with_new_x(_x)
  File "/tmp/.mount_NMRevao32Zhl/usr/src/nmreval/fit/result.py", line 404, in with_new_x
    y_values = self.func.func(self.p_final, x_values, **self.fun_kwargs)
  File "/tmp/.mount_NMRevao32Zhl/usr/src/nmreval/fit/model.py", line 129, in func
    f = self._int_func(x, *p, *self.fun_args, **kwargs)
TypeError: func() got an unexpected keyword argument 'complex_mode'

Anything else?

No response

### Current behavior Fit (straight line) seems to work well up to the fit-result-preview, even gives reasonable parameters and matches the datapoints in the fit-result-preview. However when the fit is accepted ("ok" button in the fit-result-preview dialogue) while the 'extrapolate curves' option is checked, an error message (see below) appears. The fitparameters are saved to the dataset and the fit-settings-preview appears to work with them. The actual fit or extrapolation is however not displayed and no set is created. Without the extrapolate option it works as expected. ### Version 2024-02-11 ### Expected behavior _No response_ ### Steps to reproduce _No response_ ### Log messages ```shell 12/02/2024 19:19:29 - INFO - root : Successful fit 12/02/2024 19:19:50 - ERROR - root : Uncaught exception: Traceback (most recent call last): File "/tmp/.mount_NMRevao32Zhl/usr/src/gui_qt/main/mainwindow.py", line 969, in accepts_fit self.management.make_fits(res, opts, param_graph, show_fit, parts, extrapolate) File "/tmp/.mount_NMRevao32Zhl/usr/src/gui_qt/main/management.py", line 650, in make_fits fit = fit.with_new_x(_x) File "/tmp/.mount_NMRevao32Zhl/usr/src/nmreval/fit/result.py", line 404, in with_new_x y_values = self.func.func(self.p_final, x_values, **self.fun_kwargs) File "/tmp/.mount_NMRevao32Zhl/usr/src/nmreval/fit/model.py", line 129, in func f = self._int_func(x, *p, *self.fun_args, **kwargs) TypeError: func() got an unexpected keyword argument 'complex_mode' ``` ### Anything else? _No response_

saeckech added the

Kind/Bug

label 2024-02-12 18:28:28 +00:00

dominik self-assigned this 2024-02-13 16:15:43 +00:00

dominik added this to the (deleted) project 2024-02-13 16:15:47 +00:00

dominik referenced this issue from a commit

2024-02-13 16:17:09 +00:00

remove complex kwarg when necessary (#246)

dominik closed this issue

2024-02-13 16:17:09 +00:00

Sign in to join this conversation.