IPKM/nmreval
15
2
Fork 1
Code Issues 40 Pull Requests Actions Packages Projects Releases Wiki Activity

[BUG] fit curve not plotted after preview #245

New Issue
Closed
opened 2024-02-12 18:28:28 +00:00 by saeckech · 0 comments
saeckech commented 2024-02-12 18:28:28 +00:00
Member
Copy Link

Current behavior

Fit (straight line) seems to work well up to the fit-result-preview, even gives reasonable parameters and matches the datapoints in the fit-result-preview. However when the fit is accepted ("ok" button in the fit-result-preview dialogue) while the 'extrapolate curves' option is checked, an error message (see below) appears. The fitparameters are saved to the dataset and the fit-settings-preview appears to work with them. The actual fit or extrapolation is however not displayed and no set is created. Without the extrapolate option it works as expected.

Version

2024-02-11

Expected behavior

No response

Steps to reproduce

No response

Log messages

12/02/2024 19:19:29 - INFO - root : Successful fit
12/02/2024 19:19:50 - ERROR - root : Uncaught exception:
Traceback (most recent call last):
  File "/tmp/.mount_NMRevao32Zhl/usr/src/gui_qt/main/mainwindow.py", line 969, in accepts_fit
    self.management.make_fits(res, opts, param_graph, show_fit, parts, extrapolate)
  File "/tmp/.mount_NMRevao32Zhl/usr/src/gui_qt/main/management.py", line 650, in make_fits
    fit = fit.with_new_x(_x)
  File "/tmp/.mount_NMRevao32Zhl/usr/src/nmreval/fit/result.py", line 404, in with_new_x
    y_values = self.func.func(self.p_final, x_values, **self.fun_kwargs)
  File "/tmp/.mount_NMRevao32Zhl/usr/src/nmreval/fit/model.py", line 129, in func
    f = self._int_func(x, *p, *self.fun_args, **kwargs)
TypeError: func() got an unexpected keyword argument 'complex_mode'

Anything else?

No response

### Current behavior Fit (straight line) seems to work well up to the fit-result-preview, even gives reasonable parameters and matches the datapoints in the fit-result-preview. However when the fit is accepted ("ok" button in the fit-result-preview dialogue) while the 'extrapolate curves' option is checked, an error message (see below) appears. The fitparameters are saved to the dataset and the fit-settings-preview appears to work with them. The actual fit or extrapolation is however not displayed and no set is created. Without the extrapolate option it works as expected. ### Version 2024-02-11 ### Expected behavior _No response_ ### Steps to reproduce _No response_ ### Log messages ```shell 12/02/2024 19:19:29 - INFO - root : Successful fit 12/02/2024 19:19:50 - ERROR - root : Uncaught exception: Traceback (most recent call last): File "/tmp/.mount_NMRevao32Zhl/usr/src/gui_qt/main/mainwindow.py", line 969, in accepts_fit self.management.make_fits(res, opts, param_graph, show_fit, parts, extrapolate) File "/tmp/.mount_NMRevao32Zhl/usr/src/gui_qt/main/management.py", line 650, in make_fits fit = fit.with_new_x(_x) File "/tmp/.mount_NMRevao32Zhl/usr/src/nmreval/fit/result.py", line 404, in with_new_x y_values = self.func.func(self.p_final, x_values, **self.fun_kwargs) File "/tmp/.mount_NMRevao32Zhl/usr/src/nmreval/fit/model.py", line 129, in func f = self._int_func(x, *p, *self.fun_args, **kwargs) TypeError: func() got an unexpected keyword argument 'complex_mode' ``` ### Anything else? _No response_
saeckech added the
Kind/Bug
 label 2024-02-12 18:28:28 +00:00
dominik self-assigned this 2024-02-13 16:15:43 +00:00
dominik added this to the (deleted) project 2024-02-13 16:15:47 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Crash

This issue describes unexpected shutdowns or non-responsive behaviors

  
Kind/Documentation

Improves documentation

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New feature

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Priority
Very low
The priority is very low

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid isssue

  
Reviewed/Won't Fix

This issue won't be fixed

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Status
On Hold
This issue or pull request is on hold

  
Status
Stale
Issues without activity for more than 6 months

  
Type/BDS

Issues connected to BDS

  
Type/DSC

Issues connected to DSC

  
Type/Fit

Issue is connected to fitting data

  
Type/General

issue connected to general functionality

  
Type/NMR

Issues connected to NMR

No Label
Kind/Breaking
Kind/Bug
Kind/Crash
Kind/Documentation
Kind/Enhancement
Kind/Feature
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Priority
Very low
Reviewed
Duplicate
Reviewed
Invalid
Reviewed/Won't Fix
Status
Need More Info
Status
On Hold
Status
Stale
Type/BDS
Type/DSC
Type/Fit
Type/General
Type/NMR
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
dominik
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: IPKM/nmreval#245
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?