IPKM/nmreval
12
2
Fork 0
Code Issues 34 Pull Requests Actions Packages Projects 2 Wiki Activity

[BUG] Nested Functions, Fit and Preview Failed inconsistently #279

New Issue
Closed
opened 2024-07-04 11:31:33 +00:00 by saeckech · 0 comments
saeckech commented 2024-07-04 11:31:33 +00:00
Member
Copy Link

Current behavior

Const + (Const*Func) failed.

Const + (Func*Const) worked for a single fit, then the fit failed with the error message below, after the dataset and the value of the offset (first Const) was changed.
The checkbox-preview does not work and gives the second error message below.

Version

2024-07-04

Expected behavior

No response

Steps to reproduce

No response

Log messages

Fit fail:
2024-07-04 13:26:07,142 - ERROR - Fit preparation failed with error: ('Setting parameter failed',)

Checkbox preview fail:
2024-07-04 13:29:37,856 - ERROR - Uncaught exception:
Traceback (most recent call last):
  File "/tmp/.mount_NMRevahzUaHi/usr/src/gui_qt/main/mainwindow.py", line 957, in show_fit_preview
    self.fit_dialog.make_previews(x, funcs)
  File "/tmp/.mount_NMRevahzUaHi/usr/src/gui_qt/fit/fitwindow.py", line 455, in make_previews
    y = f.func(x, *p_value, **kwargs)
  File "/tmp/.mount_NMRevahzUaHi/usr/src/nmreval/fit/_meta.py", line 187, in func
    pr, kw_right = self._right_arguments(*args, **kwargs)
  File "/tmp/.mount_NMRevahzUaHi/usr/src/nmreval/fit/_meta.py", line 175, in _right_arguments
    kw_right[k_int] = kwargs[k_ext]
KeyError: 'xaxis_3'

Anything else?

No response

### Current behavior Const + (Const*Func) failed. Const + (Func*Const) worked for a single fit, then the fit failed with the error message below, after the dataset and the value of the offset (first Const) was changed. The checkbox-preview does not work and gives the second error message below. ### Version 2024-07-04 ### Expected behavior _No response_ ### Steps to reproduce _No response_ ### Log messages ```shell Fit fail: 2024-07-04 13:26:07,142 - ERROR - Fit preparation failed with error: ('Setting parameter failed',) Checkbox preview fail: 2024-07-04 13:29:37,856 - ERROR - Uncaught exception: Traceback (most recent call last): File "/tmp/.mount_NMRevahzUaHi/usr/src/gui_qt/main/mainwindow.py", line 957, in show_fit_preview self.fit_dialog.make_previews(x, funcs) File "/tmp/.mount_NMRevahzUaHi/usr/src/gui_qt/fit/fitwindow.py", line 455, in make_previews y = f.func(x, *p_value, **kwargs) File "/tmp/.mount_NMRevahzUaHi/usr/src/nmreval/fit/_meta.py", line 187, in func pr, kw_right = self._right_arguments(*args, **kwargs) File "/tmp/.mount_NMRevahzUaHi/usr/src/nmreval/fit/_meta.py", line 175, in _right_arguments kw_right[k_int] = kwargs[k_ext] KeyError: 'xaxis_3' ``` ### Anything else? _No response_
saeckech added the
Kind/Bug
 label 2024-07-04 11:31:33 +00:00
dominik self-assigned this 2024-07-05 17:31:19 +00:00
dominik added the
Type/Fit
 label 2024-07-05 17:31:25 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Crash

This issue describes unexpected shutdowns or non-responsive behaviors

  
Kind/Documentation

Improves documentation

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New feature

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Priority
Very low
The priority is very low

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid isssue

  
Reviewed/Won't Fix

This issue won't be fixed

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Status
On Hold
This issue or pull request is on hold

  
Status
Stale
Issues without activity for more than 6 months

  
Type/BDS

Issues connected to BDS

  
Type/DSC

Issues connected to DSC

  
Type/Fit

Issue is connected to fitting data

  
Type/General

issue connected to general functionality

  
Type/NMR

Issues connected to NMR

No Label
Kind/Breaking
Kind/Bug
Kind/Crash
Kind/Documentation
Kind/Enhancement
Kind/Feature
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Priority
Very low
Reviewed
Duplicate
Reviewed
Invalid
Reviewed/Won't Fix
Status
Need More Info
Status
On Hold
Status
Stale
Type/BDS
Type/DSC
Type/Fit
Type/General
Type/NMR
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
dominik
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: IPKM/nmreval#279
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?