IPKM/nmreval
15
2
Fork 1
Code Issues 40 Pull Requests Actions Packages Projects Releases Wiki Activity

[BUG] exclude fit region gives bad fit interpolation #302

New Issue
Closed
opened 2024-12-07 13:04:01 +00:00 by saeckech · 0 comments
saeckech commented 2024-12-07 13:04:01 +00:00
Member
Copy Link

Current behavior

Fitting a pake spectrum to a Pake+Lorentz dataset and excluding the Lorentz-data yields a rectangle-shaped step in the returned pake function, see "PakeFit_ExcludeRegion_Preview". Additionally, the returned function and the updated preview are unequal, see "PakeFit_ExcludeRegion_Result"

Version

2024-11-14

Expected behavior

good fits

Steps to reproduce

No response

Log messages

No response

Anything else?

Trying to fit the data with a custom fit region with the right border on -2e4Hz, i.e. to the left of the Lorentzan-data, leads to the error
"2024-12-07 14:07:31,520 - ERROR - Residuals are not finite in the initial point."

### Current behavior Fitting a pake spectrum to a Pake+Lorentz dataset and excluding the Lorentz-data yields a rectangle-shaped step in the returned pake function, see "PakeFit_ExcludeRegion_Preview". Additionally, the returned function and the updated preview are unequal, see "PakeFit_ExcludeRegion_Result" ### Version 2024-11-14 ### Expected behavior good fits ### Steps to reproduce _No response_ ### Log messages _No response_ ### Anything else? Trying to fit the data with a custom fit region with the right border on -2e4Hz, i.e. to the left of the Lorentzan-data, leads to the error "2024-12-07 14:07:31,520 - ERROR - Residuals are not finite in the initial point."
PakeFit_ExcludeRegion_Result.png
126 KiB
PakeFit_ExcludeRegion_Preview.png
152 KiB
PakeFit_ExcludeRegion_Result.png PakeFit_ExcludeRegion_Preview.png
saeckech added the
Kind/Bug
 label 2024-12-07 13:04:01 +00:00
dominik self-assigned this 2024-12-07 13:12:53 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Crash
This issue describes unexpected shutdowns or non-responsive behaviors
Kind/Documentation
Improves documentation
Kind/Enhancement
Improve existing functionality
Kind/Feature
New feature
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Priority
Very low
The priority is very low
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid isssue
Reviewed/Won't Fix
This issue won't be fixed
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Status
On Hold
This issue or pull request is on hold
Status
Stale
Issues without activity for more than 6 months
Type/BDS
Issues connected to BDS
Type/DSC
Issues connected to DSC
Type/Fit
Issue is connected to fitting data
Type/General
issue connected to general functionality
Type/NMR
Issues connected to NMR
No Label
Kind/Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees dominik
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: IPKM/nmreval#302
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?