mhjenbaz/he-database
1
0
Fork 0
Code Issues 2 Pull Requests Actions Activity

Cleanup #1 #1

New Issue
Open
opened 2026-04-14 07:05:22 +00:00 by markusro · 0 comments
markusro commented 2026-04-14 07:05:22 +00:00
Collaborator
Copy Link
Copy Source

Hi,
I managed to make it run locally but this needs some cleanup. Some of it can be fixed automatically by a linter, for example ruff is highly recommended.

  1. there are imports scattered around for example in sheets/views.py, some are imported multiple times. Please move all imports to the top of the file.
  2. Function nop_cols_for_row in sheets/views.py is defined 2 times.
  3. Function build_halfyear_window also
  4. sheets/services/halfyear_calc.py has lots of redundant imports.
  5. urls.py: path('sheet/int:year/int:month/', MonthlySheetView.as_view(), name='monthly_sheet') is defined twice I think
  6. This looks wrong and is partially redundant: path("save-cells/", SaveCellsView.as_view(), name="save_cells"), path("save-cells/", SaveCellsView.as_view(), name="save_cells"),path('save-month-summary/', SaveMonthSummaryView.as_view(), name='save_month_summary'),
  7. what do the new/old folders contain? If they are not needed they should be removed.
Hi, I managed to make it run locally but this needs some cleanup. Some of it can be fixed automatically by a linter, for example [ruff](https://docs.astral.sh/ruff/) is highly recommended. 1. there are imports scattered around for example in sheets/views.py, some are imported multiple times. Please move all imports to the top of the file. 2. Function nop_cols_for_row in sheets/views.py is defined 2 times. 3. Function build_halfyear_window also 4. sheets/services/halfyear_calc.py has lots of redundant imports. 5. urls.py: path('sheet/<int:year>/<int:month>/', MonthlySheetView.as_view(), name='monthly_sheet') is defined twice I think 6. This looks wrong and is partially redundant: `path("save-cells/", SaveCellsView.as_view(), name="save_cells"), path("save-cells/", SaveCellsView.as_view(), name="save_cells"),path('save-month-summary/', SaveMonthSummaryView.as_view(), name='save_month_summary'),` 7. what do the new/old folders contain? If they are not needed they should be removed.
mhjenbaz was assigned by markusro 2026-04-14 07:05:22 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
markusro (Markus Rosenstihl) mhjenbaz (Mohamad Jenbaz)
No Assignees mhjenbaz
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mhjenbaz/he-database#1
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?