Hi,
I managed to make it run locally but this needs some cleanup. Some of it can be fixed automatically by a linter, for example ruff is highly recommended.
there are imports scattered around for example in sheets/views.py, some are imported multiple times. Please move all imports to the top of the file.
Function nop_cols_for_row in sheets/views.py is defined 2 times.
Function build_halfyear_window also
sheets/services/halfyear_calc.py has lots of redundant imports.
urls.py: path('sheet/int:year/int:month/', MonthlySheetView.as_view(), name='monthly_sheet') is defined twice I think
This looks wrong and is partially redundant: path("save-cells/", SaveCellsView.as_view(), name="save_cells"), path("save-cells/", SaveCellsView.as_view(), name="save_cells"),path('save-month-summary/', SaveMonthSummaryView.as_view(), name='save_month_summary'),
what do the new/old folders contain? If they are not needed they should be removed.
Hi,
I managed to make it run locally but this needs some cleanup. Some of it can be fixed automatically by a linter, for example [ruff](https://docs.astral.sh/ruff/) is highly recommended.
1. there are imports scattered around for example in sheets/views.py, some are imported multiple times. Please move all imports to the top of the file.
2. Function nop_cols_for_row in sheets/views.py is defined 2 times.
3. Function build_halfyear_window also
4. sheets/services/halfyear_calc.py has lots of redundant imports.
5. urls.py: path('sheet/<int:year>/<int:month>/', MonthlySheetView.as_view(), name='monthly_sheet') is defined twice I think
6. This looks wrong and is partially redundant: `path("save-cells/", SaveCellsView.as_view(), name="save_cells"), path("save-cells/", SaveCellsView.as_view(), name="save_cells"),path('save-month-summary/', SaveMonthSummaryView.as_view(), name='save_month_summary'),`
7. what do the new/old folders contain? If they are not needed they should be removed.
mhjenbaz
was assigned by markusro2026-04-14 07:05:22 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Hi,
I managed to make it run locally but this needs some cleanup. Some of it can be fixed automatically by a linter, for example ruff is highly recommended.
path("save-cells/", SaveCellsView.as_view(), name="save_cells"), path("save-cells/", SaveCellsView.as_view(), name="save_cells"),path('save-month-summary/', SaveMonthSummaryView.as_view(), name='save_month_summary'),